Git clone results in "fatal: Unable to find remote helper for 'https'" when using a local git executable about dugite HOT 6 CLOSED

@kittaakos ah, I think I know this one.

We set GIT_EXEC_PATH to the same known location, and at least on macOS this path may be something different. You can check this by running git --exec-path:

$ git --exec-path
/usr/local/Cellar/git/2.14.1/libexec/git-core

Two potential ways out of this:

• don't set GIT_EXEC_PATH if you already have LOCAL_GIT_DIRECTORY set, assume the user has configured Git correctly
• run git --exec-path and set it as an environment variable if you have LOCAL_GIT_DIRECTORY set

from dugite.

Thank you, @shiftkey! Both approaches work perfectly. I would say; when one sets the GIT_LOCAL_DIRECTORY variable one should be aware of setting the GIT_EXEC_PATH environment variable too.

Unfortunately, even if I set both environment variables, the GIT_EXEC_PATH gets overridden here.

The following would be my expectation about the behavior; when the custom GIT_EXEC_PATH is set, then dugite itself does not try to locate it again, but blindly uses the user specified path, just like with the LOCAL_GIT_DIRECTORY .

Would that change make sense to you? Do you accept contributions? Also, please correct me if I misunderstood something. Thanks in advance!

from dugite.

Would that change make sense to you?

Yes! This makes sense, it was just me not considering the full range of scenarios. And I like respecting the existing environment variable, as it avoids us executing a git --exec-path ourselves.

Do you accept contributions?

I do! Happy to review and work with you on a fix if you're feeling up to it!

from dugite.

Awesome! I was put on another project, but I do my best to come up with a PR in this week. Bear with me.

from dugite.

PR: #114.

from dugite.

Fixed by #114

from dugite.