Comments (2)
@kittaakos thanks for the feedback!
There's a couple of reasons we shied away from bundling more abstractions on top of this core:
- the Desktop and Atom teams were focused on these releases, so we baked our own abstractions into our projects for the sake of convenience.
- Git gives you the ability to pretty print for some commands, so you'll see things (like log for example) are tuned for just the information we want in the app.
There's probably some value in this, we just haven't had the time to think about it.
In response to your question:
- it should be possible to reuse
desktop
commands and models in a downstream npm package. (Please note, we cannot have a dependency onelectron
.)- you have already planned to decouple the commands and model from the UI and redistribute them without the electron application.
We don't have plans to extract the stuff we've been building out into it's own package, or push it down into dugite
itself. Maybe once things stabilize, if people are interested in reusing that stuff (it is in TypeScript, and not everyone is into that). But the Desktop team is focused on migrating people away from the existing applications, which requires feature work and bugfixes first.
I think I'm okay with this if you wanted to build upon dugite
and provide those abstractions, but be aware that much of the stuff in Desktop is subject to change (I'm making big changes to status
at the moment, for example) so I'm not sure we'd take a dependency on an abstraction anytime soon.
cc @BinaryMuse @kuychaco @smashwilson @desktop/core for feels
from dugite.
Thank you for your feedback and clarification, @shiftkey.
I close this ticket now. Once we have the npm package with the commands and models built on the top of your work, I will share it here. Others might find it useful.
from dugite.
Related Issues (20)
- Use in React Native HOT 1
- dugite/package.json: Unexpected end of JSON input in Electron 11 beta HOT 3
- GitProcess.exec cause CPU 100% and never resolve in Electron HOT 2
- Return process or PID in IGitResult HOT 7
- Slow tests fail on missing repository HOT 2
- Stream Commands to GitProcess HOT 3
- Any way of stopping Dugite from downloading Git? HOT 2
- ChainAlert: npm package release (1.108.0) has no matching tag in this repo HOT 2
- Simultaneous async git operations - best practice? HOT 1
- Proxy support seems to have regressed HOT 3
- How to run git command interactively?
- 'subtree' is not a git command
- Github Desktop Dugite fails on arm64 linux HOT 1
- rmSync is not defined HOT 1
- `execTask.cancel()` doesn't kill the git process properly HOT 4
- Missing require in dugite/script /download-git.js HOT 1
- Git exec takeup 500MB when installed with pnpm HOT 1
- Drop `electron` from repository tags HOT 3
- Request: Publish version 2.5.2 to the npm package registry HOT 2
- Unable to use git difftool? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dugite.