Support for ethers.js about typechain HOT 45 CLOSED

@krzkaczor funded! Looking forward to the result :)

For any interested bounty hunters, this is an Approval Required bounty so please comment with a short plan of attack to be considered for it. Happy hunting!

from typechain.

@mkosowsk thanks for funding!!!

My pleasure 👍 funded from the ECF Web 3.0 Infrastructure Fund, so thanks to the Ethereum Community Fund!

from typechain.

Hi @kpulkit29, unfortunately after internal discussion my team has decided to remove you from this bounty as we feel that it was not appropriate for your skillset.

To other bounty hunters, this issue is now once again open. Please feel free to apply and list a plan of attack that takes into account recent comments from @krzkaczor. Thanks!

from typechain.

Pushed a few commits. If you want me to update the docs too, please let me know.

from typechain.

@krzkaczor Mind adding a bit more detail on an 'Acceptance Criteria' for this PR to be merged? This will help clarify to potential contributors on your expectations 👍

from typechain.

@vs77bb updated ticket description.

from typechain.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 200.0 DAI (200.0 USD @ $1.0/DAI) attached to it.

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $30,076.81 more funded OSS Work available on the Gitcoin Issue Explorer

from typechain.

I request you to shed a little more light on what exactly needs to be done.This will help avoid any hassle

from typechain.

0x created typings for lib itself: https://www.npmjs.com/package/ethers-typescript-typings what we need is to generate dynamically typings for contracts:

const contract = new ethers.Contract(address, abi, provider); // this is `any`

docs

I think it could be implemented like it's done in web3js target so new ethers.Contract<T>(address, abi, provider) // returns T wrapper has type parameter.

Please read truffle target source code in this project, beacuse it will be very similiar. We need to generate typings based on ABI and then have a way to plug them easily into ethers.Contract calls.

from typechain.

@mkosowsk thanks for funding!!!

from typechain.

from typechain.

from typechain.

@kpulkit29 you're talking about deploying in tests right? I think it doesn't make much differnt — use whatever is easier for you.

from typechain.

the dumbContract.spec.ts in targets/web3-1.0.0 there is a import
import { DumbContract } from "./types/web3-contracts/DumbContract";
Cannot locate this file

from typechain.

@kpulkit29 it's a generated file by typechain — it should not be a part of git repository as explained in readme. Just run yarn test and it will be there.

from typechain.

from typechain.

@kpulkit29 PR? I am not sure what's you're talking about

from typechain.

New pr #101

from typechain.

Please review and suggest how should I go ahead with writing tests

from typechain.

Please suggest so that I can go ahead

from typechain.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 200.0 DAI (200.0 USD @ $1.0/DAI) has been submitted by:

1. @kpulkit29
2. @Destiner

@mkosowsk please take a look at the submitted work:

• PR by @Destiner
• PR by @kpulkit29

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $50,620.86 more funded OSS Work available on the Gitcoin Issue Explorer

from typechain.

Hi @krzkaczor does @kpulkit29's PR satisfy the requirements for this issue? If not, what steps need to be taken! Thanks :)

from typechain.

from typechain.

@kpulkit29 noted :) Just confirming with @krzkaczor that the PR satisfies the requirements before paying out the bounty 👍

from typechain.

@kpulkit29 what you did so far looks more or less fine.

Now you need to create actual target implementation as shown here: https://github.com/ethereum-ts/TypeChain/blob/master/lib/targets/truffle/index.ts This doesn't generate any new typings so far.

from typechain.

@mkosowsk it's not mergable now, I will let you know when it is. I am on vacation now so i can't respond too often.

from typechain.

from typechain.

from typechain.

from typechain.

from typechain.

@kpulkit29 No it's still not what it was supposed to be.

• generated stuff should be just typings no real class impl, look how Truffle target is done
• tests are not using generated wrappers (?)
• you didn't remove package.lock file
• tests don't pass

TBH: I submitted Gitcoin request b/c I don't have time to work on this issue but I think it requires more understanding of the project and problem — otherwise, I spent more time managing and checking PRs that I would spent developing it. CC: @mkosowsk

from typechain.

@krzkaczor noted, will discuss internally for you and come back with something 👍

from typechain.

from typechain.

Hi there. I've managed to write generator for ethers and it seems to be working fine for both functions and events. What's left is basically to write tests and solve minor design tasks.

Do you want me to pursue it?

from typechain.

@Destiner yes, of course! :) Please submit PR when you're ready.

from typechain.

Cool!

Few questions:

• ethers.js Contract provides two ways of calling functions: contract.functions.funcName and contract.funcName. I made the implementation for the first method, should we also add support for the second one? I wasn't sure whether it's redundant or not.
• ethers.js Contract also provides an ability to estime gas costs for calls via contract.estimateGas.funcName. I think we want to add typings for this as well.

from typechain.

from typechain.

Hi @Destiner please apply for work here and you will be approved to work on this bounty of 200 DAI. Thanks!

from typechain.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 6 months, 2 weeks from now.
Please review their action plans below:

1) destiner has been approved to start work.

The code for the new target is already written, what's left is to write tests and probably update docs.

Learn more on the Gitcoin Issue Details page.

from typechain.

Applied on Gitcoin and will submit PR tonight.

from typechain.

@Destiner approved! Looking forward to the PR!

from typechain.

@Destiner thanks for your PR! I accpeted and merged it! I will update changelog and readme any second.

@mkosowsk thanks for funding and I agree that @Destiner should receive a bounty :)

from typechain.

Great! @Destiner please submit your work here and I will pay out ASAP from the ECF Web 3.0 Infrastructure Fund 👍

from typechain.

Thanks! Submitting it.

from typechain.

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 200.0 DAI (200.0 USD @ $1.0/DAI) attached to this issue has been approved & issued to @Destiner.

• Learn more on the Gitcoin Issue Details page
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $50,441.41 more funded OSS Work available on the Gitcoin Issue Explorer

from typechain.