Comments (4)
I've only been marking functions as weak as a convenience for some of hooks that have default / no-op implementations in dummy.c
.
In general, to customize the behavior for a target, I would either add more #ifdef
controlled code to target_stm32f103.c
or create a new target directory if the changes are not broadly applicable or too extensive to put in the common implementation.
from dapboot.
Just in terms of extensibility without butchering the core code, I've been finding the weak functions really nice. It's meant that I can extend the code for a weird use case without junking up the core implementation and still keep the cut-and-paste duplication to a minimum.
from dapboot.
Weak functions work okay if there's only one level of overriding necessary, but IIRC, it's not defined what happens if you provide multiple weak definitions of a symbol to the linker. I agree that it is nice to be able to extend things without modification, but there are only so many hacks we can get away with before we end up building a poor version of C++.
from dapboot.
Understood.
from dapboot.
Related Issues (20)
- Windows 7 weird performance. Hangs after download is finished HOT 5
- CubeMX minimal example not working correctly HOT 2
- Add delay before reading the button
- Add attribute to avoid a warning by GCC
- Add #ifndef in generic.h, so we can override without local.mk HOT 2
- STLINK_HIGH doesn't fit into flash HOT 12
- Unable to use hex file with WebUSB HOT 4
- Uploading using st-flash removes access to bootloader HOT 3
- GD32F30x support HOT 2
- Missing usb_bos_descriptor typedef and defines HOT 8
- jump_to_application doesn't clean up after dapboot HOT 2
- When the bin file download is being done, how I return the device from DFU to UART? HOT 2
- Can someone explain little more about how to build the DFU binary?
- Thanks! HOT 2
- Flashing dapboot-v1.20 using openocd
- SET ADDRESS Error on upload my firmware HOT 2
- Where is winusb descriptor string defined? HOT 2
- PR of `usbd_register_extra_string` commit from devanlai/libopencm3? HOT 2
- [Feature Support]Add support for STM32F303 MCU HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dapboot.