Giter VIP home page Giter VIP logo

Comments (8)

sutarmin avatar sutarmin commented on June 14, 2024

main in package.json must be returned back to dist/remote-data.js. io-ts type must be imported from remote-data-ts/remote-data-io directly. This will be a breaking change. /cc @mlegenhausen

from remote-data-ts.

raveclassic avatar raveclassic commented on June 14, 2024

This is a regression after #19

from remote-data-ts.

raveclassic avatar raveclassic commented on June 14, 2024

We need to decide wether we want to keep all modules in the lib consistent.

  • If we remove direct reference from main module (index) to the module importing io-ts then we break consistency, end user will never know where exactly he'll receive "mising module" error.
  • If we remove main module (index) completely (which I'd prefer personally) we'll end up with inability to import directly from package from 'remote-data-ts'. Need to check how will this affect IDE autoimports etc.
  • On the other hand io-ts types is the functionaly of this lib as a whole so I'm not sure wether we should split it into separate incosistent modules. That's why io-ts and io-ts-types were added to peer-dependencies together with added index.ts - this is the main entry point which composes separate modules into the lib. Perhaps we could consider moving the libs from peer-dependencies to dependencies with a relaxed version (like '*').

/cc @mankdev

from remote-data-ts.

raveclassic avatar raveclassic commented on June 14, 2024

Removing the bug label because it's not as bug, new libs appear in npm warning about missing peer-dependencies.

from remote-data-ts.

raveclassic avatar raveclassic commented on June 14, 2024

I'll also update the commit tree with a BREAKING CHANGE: label and regenerate changelog later.

from remote-data-ts.

mlegenhausen avatar mlegenhausen commented on June 14, 2024

@raveclassic I like the third solution.

from remote-data-ts.

raveclassic avatar raveclassic commented on June 14, 2024

So after a brief discussion it was decided to move peer-dependencies to dependencies.
@scink Could you update #24 (and rename) accordingly?

from remote-data-ts.

scink avatar scink commented on June 14, 2024

sure

from remote-data-ts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.