Update to version 3.x breaks Avalonia projects about gitinfo HOT 2 CLOSED

It's not GitInfo that's the problem directly, but rather its dependency ThisAssembly.Constants.

The InjectConstantAdditionalFiles target depends on PrepareResourceNames.
This causes it to run much earlier in the build pipeline that normally, causing the issue. The EmbeddedResource added by Avalonia is only added after, doesn't get a target path and thus isn't embedded.

I'm not familiar with ThisAssembly targets so I don't know why this dependency is here. Usually extra files should be added before AssignTargetPaths (called by PrepareResourceNames) runs to get correct paths (here it's not a Content or EmbeddedResource so it doesn't matter).

The theoretical fix here should be to remove this dependency, as running before PrepareForBuild should be sufficient. In practice, I know from experience that finding the right MSBuild target to anchor to can cause some serious headaches :)

This could also be fixed on the Avalonia side by depending directly on AssignTargetPaths. However, I think ThisAssembly making AssignTargetPaths runs so soon might cause issues in other packages.

from gitinfo.

Thanks a lot @MrJul for the analysis! It was key to finding out a quick fix :)

from gitinfo.