Giter VIP home page Giter VIP logo

Comments (9)

gbobr avatar gbobr commented on August 16, 2024

Update:
Examining logs i found out that it is looking for a file named 3.tar.gz when my template file is 7.tar.gz

from gamepanelx-v3.

gbobr avatar gbobr commented on August 16, 2024

Another update:
Looks like the problem is that it is always trying to use the first default template.

I had template id 3 as default for network server 1
template id 6 as default for network server 2
and template id7 as not default for network server 2

When creating a gameserver on network server 2, it always tried template id 3 that doesn't exist in network server 2.
Changed template id 3 to not default and it worked with template id 6

It will never install template id 7, even when i choose it because it always uses the first default template.

from gamepanelx-v3.

gbobr avatar gbobr commented on August 16, 2024

Yet another update:
My newly installed server keeps failing to start.
GamePanelX is trying to start it in network server 1 isntead of network server 2 where it is installed. :/
I can see the startup error in server 1 servers.log

from gamepanelx-v3.

gbobr avatar gbobr commented on August 16, 2024

Yet anoooother update:

Looking at sourcecode, the startup problem was related to "restart" method in servers class looking at network's "parentid" (line 140) and that "parentid" being 0 for main ip's on each network server.

My server id was 7, with parentid 0 because it was the main ip. Changed parentid to 7 and then startup worked.

from gamepanelx-v3.

gbobr avatar gbobr commented on August 16, 2024

I fixed this bug on pull request #18
Please accept it.

Still not sure if it will work with non-default templates, but the primary issue is fixed :D

from gamepanelx-v3.

gbobr avatar gbobr commented on August 16, 2024

I kept testing, and the initial bug is not fixed yet.

Gpx is still trying to use the first default template it finds when creating a server.
This causes two problems:

  • You can't install a server with a template that is not default.
  • If you have two servers, it might try to use the default template for the wrong server resulting in a failed installation.

The proposed pull request, anyway, fixes the startup and stop problem, and maybe many other problems related with multi-networkserver installations.
So please, consider it.

from gamepanelx-v3.

devryan avatar devryan commented on August 16, 2024

You don't have to dig into it so much in the future; simply opening a bug request is enough :) -- mainly since I know the codebase so well. I do appreciate you trying to check it out though.

This is actually because when the create server function runs, it's just grabbing the default template and ignoring the one you choose. I will fix this in a few minutes.

from gamepanelx-v3.

gbobr avatar gbobr commented on August 16, 2024

Sory if this bothered you.
I tried to fix this bug because i needed my panel working asap.
I can't promise i will not dig into it in the future, i'm a developer, it's in my nature.
I can only promise i will be less verbose when digging in :)

Thank you

from gamepanelx-v3.

devryan avatar devryan commented on August 16, 2024

This was fixed in the recent commit: cda1205

from gamepanelx-v3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.