crate-private type `Outlines<'_>` in public interface about swash HOT 8 CLOSED

Before #46 it will build with rustc as old as 1.74, after, it will build with rustc as old as 1.65.

from swash.

Hi, Would it be possible to fix this and create a new release please?

This currently broke iced framework and my local app. I can create PR for it if needed, but it looks that the change is simple to remove(crate) from this line pub(crate) struct Outlines<'a>.

Thank you!

from swash.

Please see if #45 fixes this.

from swash.

Thank you, but it looks that I still have a problem, this time:

/     pub fn draw(
197 | |         &self,
198 | |         subfont: &Subfont,
199 | |         glyph_id: GlyphId,
...   |
202 | |         pen: &mut impl Pen,
203 | |     ) -> Result<(), Error> {
    | |__________________________^ can't leak crate-private type
...
292 |   pub(crate) struct Subfont {
    |   ------------------------- `Subfont` declared as crate-private

So the same problem for struct Subfont

from swash.

BTW I have the same issues if I clone this repo and run cargo build

from swash.

@klangner what rustc version do you have? I can't reproduce it on rustc 1.74 (still want to fix it to continue working with older versions)

from swash.

I've verified that #46 fixes that issue, and allows building with rustc as old as 1.65

from swash.

I have 1.72.1 I can upgrade if this will solve this problem. I can also make fork fix it and send PR if you want.

BTW there are also several warnings during the build.
Like:

warning: field `flags` is never read
   --> src/strike.rs:783:9
    |
779 | struct BitmapData<'a> {
    |        ---------- field in this struct
...
783 |     pub flags: u8,
    |         ^^^^^
    |
    = note: `BitmapData` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
    = note: `#[warn(dead_code)]` on by default

from swash.