Giter VIP home page Giter VIP logo

Comments (1)

i5heu avatar i5heu commented on August 15, 2024

Ohhh wow i found the error... this is some forgotten semicolon level stuff:

if forgot to copy the chunk variables for the goroutines and their pointer got assigned a new value while the goroutines where running.
This took me way to long to catch.

And also i tested all modes with up to 10000 concurrencies and it seams to work!

Maybe not so obvious but one needs to do this in a for loop with wb.Set too, i guess because wb.Set is only executed when wb.Flush() is called.

func (k *KeyValStore) BatchWriteChunk(chunks []buzhashChunker.ChunkData) error {

	wb := k.badgerDB.NewWriteBatch()
	defer wb.Cancel()

	for _, chunk := range chunks {
		chunk := chunk // important

		atomic.AddUint64(&k.writeCounter, 1)
		err := wb.Set(chunk.Hash[:], chunk.Data)
		if err != nil {
			log.Fatal("Error writing chunk: ", err)
			return err
		}
	}

	return wb.Flush()
}

This is even defined in the documentation

https://pkg.go.dev/github.com/dgraph-io/badger#Txn.Set

from badger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.