Giter VIP home page Giter VIP logo

Comments (7)

paulftw avatar paulftw commented on August 24, 2024

Hi @onedrawingperday, thanks for getting in touch and thanks for doing the hard work of maintaining this great project.

Although hugo-dgraph-theme is open source it is not maintained for general purpose use - we built it for our blog and as we aren't designers I don't think it's good enough to be useful to others out-of-the-box.

We welcome anyone to fork it and do whatever the current license (MIT) permits, but providing support for external builds is something I don't have resources for.

I deleted the exampleSite because someone raised an issue that it was broken, and I didn't want to mislead anyone into thinking that exampleSite is maintained.

We test our theme every time we update our blog and that's been good enough for now.
With HugoBasicExample I'm not even sure where to start integrating it.

Can you recommend a low maintenance approach to keep the theme in the gallery or could you just drop it from there?

from hugo-dgraph-theme.

onedrawingperday avatar onedrawingperday commented on August 24, 2024

Can you recommend a low maintenance approach to keep the theme in the gallery or could you just drop it from there?

We can add this theme to the noDemo list of the Build Script so that it doesn't throw errors during deployment.

I will send a PR to the Hugo Themes repo. If it's accepted I will let you know.

from hugo-dgraph-theme.

onedrawingperday avatar onedrawingperday commented on August 24, 2024

The PR to add this theme in the noDemo array of the Hugo Themes Site Build Script was merged earlier.

from hugo-dgraph-theme.

manishrjain avatar manishrjain commented on August 24, 2024

Hey guys,

I'm a big fan of Hugo. I'm not sure how much work is it, but @paulftw if you can fix up the issues and make it workable, I'd like the theme to be featured the same way as it was before.

Thanks for letting us know, @onedrawingperday . We'll get back with some update and direction.

from hugo-dgraph-theme.

onedrawingperday avatar onedrawingperday commented on August 24, 2024

@manishrjain

When gohugoio/hugoThemes#576 is merged it will be possible to have your theme's demo published once again on the Hugo website.

However the logo in the header will be 404 because your associate deleted the exampleSite.

You really need to revert commit cb69c26 for your theme's logo to appear as it was before.

Let me know once this issue is addressed so that I can remove your theme from the noDemo array of the Hugo Themes Site Build Script.

from hugo-dgraph-theme.

paulftw avatar paulftw commented on August 24, 2024

Hey @onedrawingperday I've put the ExampleSite back and also tested the theme with the HugoBasicExample you've linked when opening the issue.

Is this enough to fully re-enable our theme in the gallery?

Please let me know what else I can do to improve presentation and make it more useful.

from hugo-dgraph-theme.

onedrawingperday avatar onedrawingperday commented on August 24, 2024

@paulftw Thank you for issuing a fix to this issue. There is nothing more that needs to be done from your part.

Once gohugoio/hugoThemes#591 is merged in the Hugo Themes repo and themes are updated the DGraph theme demo will generate on the Hugo website once again as it was except for its content that currently is inherited from the HugoBasicExample due to gohugoio/hugoThemes#547

I'm closing this issue as it is fixed.

from hugo-dgraph-theme.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.