Butcher doesn't drop cleaver on Single Player about devilution HOT 7 CLOSED

Good that you added a dedicated issue for us to track this.

from devilution.

If possible, post a random seed and upload a save file. It may be the case that this always happens, still, good to have for reproduceability.

from devilution.

This has always been the case seen Devilution first compiled (and dungeons actually work lol).

It's likely a signage issue with one of the flags, since the game will compare gbMaxPlayers and the monster id.

from devilution.

Seed: 699653937
Character: https://xyinn.org/diablo/debug/single_0.sv-2018-06-29-0845

Butcher already complete on this char (Obviously).

from devilution.

Can confirm this bug. The Butcher dropped Spiked Club for me.
Compiled under debug, seed: 708591219

from devilution.

I can confirm... Uploading save file.

https://files.fm/u/rj476j9c

I will look into this in a few.

I am starting at here... and will try to follow it down.

0043171D

They're a few issues I think.
Magic items are only dropping becasue of this function

int __fastcall CheckUnique(int i, int lvl, int uper, bool recreate)
...
...
if ( random(28, 100) > uper )
//This above returns
/*
random returns
eax 0x59 :89
ecx C4460E56
edx 0x59 : 89
*/

According to the asm , it looks like it expects the value to be below 15 , otherwise it will jump to making a unique item.

Once that completes, It will grab a unique item using ECX and EDX. EDX will hold the index of the unique item . So ideally you can make this 0 and get the cleaver. I am still looking at this though.

EDIT what I am doing isn't right. I need to step back a bit and see why the butcher would generate such a high RNG.

from devilution.

This issue was caused by the signage of MData->mTreasure. When the code was decompiled, I had this field entered as signed short, but later on it was correct to be unsigned. This however was not reflected in the actual code. It's been fixed now, Butcher drops the Cleaver. 56e625c

from devilution.