UnsupervisedFeedbackHandler - 500 error/NullPointerException (Solr 6.3.0) about relevancyfeedback HOT 3 CLOSED

Committed PR. Should address this.

from relevancyfeedback.

@jstol how are you call it and how is it configured? Are you using the 6.30 branch? It's quite easy to attach solr to the debugger if needed to debug this sort of issue. I can't say from just the stack trace what's going on. Are you passing in the mm parameter? If so, make sure you are using the correct format, and try removing it and allowing it to use the default. If you are not specifying it, try specifying it. But knowing your solr version, your config and providing me an example of how it's being called would help me troubleshoot it.

from relevancyfeedback.

@simonhughes22 thanks for getting back to me. I was using master (based on the part of the README that says "Solr 6.3 (see branch) also master"), but I'll try out the Solr.6.3.0 branch to see if I get the same issues.

My configuration was basically the same as in your example, but for the initial retrieval step I configured defType to dismax by default and only set a df of "text" - no other default settings.

ie. the section with:

<!-- Regular query configuration -->
<str  name="defType">edismax</str>
<str  name="df">title</str>
<str  name="qf">title^1.5   skills^1.25 description^1.1</str>
<str  name="pf2">title^3.0  skills^2.5  description^1.5</str>
<str  name="mm">1</str>
<str  name="q.op">OR</str>

became something similar to:

<!-- Regular query configuration -->
<str  name="defType">dismax</str>
<str  name="df">title</str>

(And of course I changed field names as needed). Not sure if the handler was designed to assume that a default mm parameter is specified within this section, but I seemed to get an exception without it.

I ended up attaching the debugger and stepping through the code to figure out where I was having my issues. I submitted some changes in a pull request, which you can see here: #3. It seems like a default value for mm isn't set within UnsupervisedFeedbackHelper, which was causing it to throw an Exception. Not sure if I modified it to handle it properly, though.

Thanks!

from relevancyfeedback.