Is it possible to add `_or` operator? about gendry HOT 4 CLOSED

Relative issue: #34 .

from gendry.

@Colstuwjx @cncal Yes, we can. The reason I didn't support _or at the begining is that, if I support _or, it's inevitable people will write codes like this:

map[string]interface{}{
  "_or": map[string]interface{}{
     "id >": 5,
     "_or": map[string]interface{}{
       "_or": map[string]interface{}{
         // ...
       }
     }
  }
}

And it'll soon become hard to understand.

But now, I think it's Okay. People know what they're doing. So, I will add the feature soon. Or if you like, it's welcome to send a pr for this

from gendry.

I agree that introducing nested _OR would make it hard to understand. Besides, We've been supported sth like this:

where := map[string]interface{}{
	"city in": []string{"beijing", "shanghai"},
	"score": 5,
	"age >": 35,
	"address": builder.IsNotNull,
	"_orderby": "bonus desc",
	"_groupby": "department",
}

if we decide to support _OR primitive, I suggest just take one layer, and suggest users take NamedQuery if the SQL is nested OR query. Otherwise, the where may grows big and hard to maintain the impl.

from gendry.

I have been proposed a draft PR #77 for this issue, Let's talk the details inside PR comments :)

from gendry.