Only re-render if action creator returns an object about react-waterfall HOT 6 OPEN

@didierfranc @runemadsen @bravomartin ^ here is a PR

from react-waterfall.

@runemadsen Could you utilise the shouldComponentUpdate lifecycle method to solve your issue?

from react-waterfall.

Yes, we are currently using shouldComponentUpdate as a workaround. However:

1. We have hundreds of connected components that have to do deep equality checks every 100ms. This is a significant performance hit that could be entirely eliminated with a single if() statement in react-waterfall that does not break the current API.

2. I would argue that the current functionality is undesirable. In a component, I can easily fetch new data and only call setState if the data is different. This is currently impossible in react-waterfall, as setState will be called on every action call, even ones that return nothing. This patterns prevents us from really embracing the store philosophy because we have no ability to perform heavy data fetching without also introducing heavy component logic. PureComponent is no help since connect() creates a new object every time it is called, so the shallow equality check does not work.

I will happily send a PR if it's wanted.

from react-waterfall.

any interest on this?
It would solve my problem too :)

from react-waterfall.

@runemadsen A PR will be great and will solve a real issue ;)

from react-waterfall.

Excellent! That's exactly what I need.

Also very clean implementation 👍

@didierfranc please take a look and merge away 💯

from react-waterfall.