Giter VIP home page Giter VIP logo

Comments (7)

DidierMurilloF avatar DidierMurilloF commented on July 18, 2024 1

Thanks for the suggestions. I will do the changes about dependencies.

from fieldhub.

DidierMurilloF avatar DidierMurilloF commented on July 18, 2024 1

I fixed some bugs of FielDHub at R Version 3.6. Now, all examples are running well and the R CRAN check is successful. Please, let me know anything that you need from me. Thank you!

from fieldhub.

DidierMurilloF avatar DidierMurilloF commented on July 18, 2024

Hi ThiagoOliveira,

Thank you for your time dedicated to testing FielDHub. I ran the same example, and it works well. I wonder if you generated the synthetic data before running the example. Just like in the documentation example,

library(FielDHub)
checks <- 5;expts <- 5
list_checks <- paste("CH", 1:checks, sep = "")
treatments <- paste("G", 6:725, sep = "")
BLOCK <- c(rep("ALL", checks), rep(1:expts, c(150,155,95,200,120)))
treatment_list <- data.frame(list(ENTRY = 1:725, NAME = c(list_checks, treatments), BLOCK = BLOCK))
head(treatment_list, 12)
ENTRY NAME BLOCK
1 1 CH1 ALL
2 2 CH2 ALL
3 3 CH3 ALL
4 4 CH4 ALL
5 5 CH5 ALL
6 6 G6 1
7 7 G7 1
8 8 G8 1
9 9 G9 1
10 10 G10 1
11 11 G11 1
12 12 G12 1
tail(treatment_list, 12)
ENTRY NAME BLOCK
714 714 G714 5
715 715 G715 5
716 716 G716 5
717 717 G717 5
718 718 G718 5
719 719 G719 5
720 720 G720 5
721 721 G721 5
722 722 G722 5
723 723 G723 5
724 724 G724 5
725 725 G725 5

then, the example runs well,

spatDB <- diagonal_arrangement(nrows = 30, ncols = 26,

  •                            checks = 5, 
    
  •                            plotNumber = 1, 
    
  •                            kindExpt = "DBUDC", 
    
  •                            planter = "serpentine", 
    
  •                            splitBy = "row", 
    
  •                            data = treatment_list)
    

[1] 725
[1] 725
[1] 725
[1] 725
[1] 725
[1] 725
[1] 725
[1] 725
[1] 725
[1] 725
[1] 725

spatDB$infoDesign
$Lines
[1] 150 155 95 200 120

$checks
[1] 5

$RepChecks
1 2 3 4 5
12 11 12 12 13

$percentChecks
[1] "7.7%"

$Fillers
[1] 0

$seed
[1] 878.1893

Please, let me know if you can run it. Thanks

from fieldhub.

Prof-ThiagoOliveira avatar Prof-ThiagoOliveira commented on July 18, 2024

I tested it again using the Linux terminal, and the same problem has happened, as you can see in my log file. Some other problems arise from other examples, but I am still verifying what is happening. Could you, please, use the function devtools::check() to check your package dependencies and function, and leave here the logfile? (or R CMD check --as-cran package_name)

00check.log

from fieldhub.

DidierMurilloF avatar DidierMurilloF commented on July 18, 2024

Actually, FielDHub passed all tests and ran the examples in win 10 and centos 7 using R Version 4.0. But let me check it in Linux and R 3.6 version. I am going to check the function getData(). Thank you!.

from fieldhub.

Prof-ThiagoOliveira avatar Prof-ThiagoOliveira commented on July 18, 2024

Ok. If the package is working using R version 4.0, I suggest you include Depends: R (>= 4.0) in your description file. When you have discovered what is happening in R 3.6, you can update the description file again (Depends: R (>= 3.6)). At least, this is a straightforward solution to the end-user. As this is also a workflow for a shiny app output, I suggest you include the shiny version. Ex.: shiny (>= 1.4.0.2), shinydashboard (>= 0.7.1), shinydashboardPlus (>= 0.7.0),...

from fieldhub.

Prof-ThiagoOliveira avatar Prof-ThiagoOliveira commented on July 18, 2024

I confirm all bugs were fixed. Thanks!

from fieldhub.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.