Importing apollo-link-sentry package gives 350kb of unwanted and unused code. about apollo-link-sentry HOT 5 CLOSED

🎉 This issue has been resolved in version 3.3.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

from apollo-link-sentry.

Using chrome's code coverage here is how chunk changed after removing apollo-link-sentry from the project (before, after):

Reduction of total size ~230kb
Reduction of unused size ~170kb

from apollo-link-sentry.

Open for suggestions or pull requests to fix this, I do not plan to work on this myself.

from apollo-link-sentry.

In my project I don't have problem with so much code added by apollo-link-sentry. I think it's because:

1. most of dependencies has already existed in project (@apollo/client, zen-observable-ts, @sentry/browser and graphql)
2. Tree shaking works well (I use Parcel 2.x)

Anyway I suggest to drop some dependencies that seems unecessary to me. I can prepare PR when agreed. E.g.:

• deepmerge which is used to merge options with default options. Because options has well known (and very simple) shape, we can achieve the same with following and save 3 kB.

export function withDefaults(options: SentryLinkOptions): FullOptions {
  return {
    …defaultOptions,
    …options,
    attachBreadcrumbs: {
      …defaultOptions.attachBreadcrumbs
      …options?.attachBreadcrumbs
    }
  };
}

• dot-props – 7 kB of code to just pick properties from operation context. Let's make option.attachBreadcrumbs.includeCache a callback to give user same capability with no dependency needed. This change would be breaking though.

from apollo-link-sentry.

I can prepare PR when agreed.

Please do, I am fine with releasing a new major version that breaks things. Consider https://github.com/angular/angular/blob/main/CONTRIBUTING.md#-commit-message-format.

from apollo-link-sentry.