Giter VIP home page Giter VIP logo

Comments (6)

timkindberg avatar timkindberg commented on July 3, 2024 1

🤦 I had TS 3 running in PyCharm in my project... that's why it worked in your project... cause it picked up the right version. Easy fix. Sorry for the distraction.

from constate.

diegohaz avatar diegohaz commented on July 3, 2024

This should work. Can you create a CodeSandbox demonstrating the issue?

from constate.

timkindberg avatar timkindberg commented on July 3, 2024

https://codesandbox.io/s/constatetypeinference-eheo9

Hmm it works there... and it works in VS Code... damn maybe a Jetbrains bug. Are you using like a really new TS feature or something?

VS Code Screenshot:
image

from constate.

timkindberg avatar timkindberg commented on July 3, 2024

I made a Jetbrains issue: https://youtrack.jetbrains.com/issue/WEB-51538

if you can provide any additional context or guesses on that ticket please feel free. My guess is they have to update their TS service or you used some TS 4 feature that PyCharm has trouble with (but not sure why if they use the right TS service).

from constate.

timkindberg avatar timkindberg commented on July 3, 2024

Ok so not sure if you are open to this, but if you rewrite the types like this, then it works in PyCharm and VS Code, IMO it's a bit cleaner too :)

import * as React from "react";
declare type Selector<Value> = (value: Value) => any;
declare type SelectorHooks<Selectors> = {
    [K in keyof Selectors]: () => Selectors[K] extends (...args: any) => infer R ? R : never;
};

// Here's the change...
// Removed the Hooks type and just did the `extends` check right here
declare type ConstateTuple<Props, Value, Selectors extends Selector<Value>[]> = Selectors["length"] extends 0
  ? [React.FC<Props>, () => Value]
  : [React.FC<Props>, ...SelectorHooks<Selectors>];

declare function constate<Props, Value, Selectors extends Selector<Value>[]>(useValue: (props: Props) => Value, ...selectors: Selectors): ConstateTuple<Props, Value, Selectors>;
export default constate;

from constate.

timkindberg avatar timkindberg commented on July 3, 2024

Hmm ok that was when I just hacked them real quick from the node_modules folder... but I've got a fork of constate open and I'm having trouble getting the types to behave...

Oddly, the types are working properly in PyCharm when I am in YOUR project's index.ts file:
image

Maybe it's something to do with how the types were exported??

from constate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.