Giter VIP home page Giter VIP logo

Comments (6)

sebastian avatar sebastian commented on July 28, 2024

I don't think it is a good idea to manually build the query AST in JS land. It couples the Frontend and Backend internals too much. Sending a SQL statement feels cleaner.

Yes, building the AST in JS only made sense as long as the AST could immediately be executed there too.

from desktop.

sebastian avatar sebastian commented on July 28, 2024

I vote for Option 1 too.

I additionally vote for using JSON as the output as it's easier to use in the frontend than parsing some CSV output.

We can live without progress reports, and if we need it later we can get hacky then.

from desktop.

edongashi avatar edongashi commented on July 28, 2024

Do we drop the JS CSV parser? If yes, do we use the backend to figure out the shape when we load a file?
If not, we need to use 2 different CSV libraries where each may have their own tiny differences.

from desktop.

sebastian avatar sebastian commented on July 28, 2024

Do we drop the JS CSV parser? If yes, do we use the backend to figure out the shape when we load a file?
If not, we need to use 2 different CSV libraries where each may have their own tiny differences.

Good point, @edongashi.

We either need another parser for the GUI or need to extend the Reference with an endpoint that returns a schema...
In either case, as long as we want to support CSV, it seems the CLI interface must be extended to support providing a schema as part of the input too!?

from desktop.

cristianberneanu avatar cristianberneanu commented on July 28, 2024

I say we do the CSV parsing only in the backend/reference tool.
To load the initial raw data (including the schema) the frontend could issue a standard SELECT * FROM 'file_name' query.

from desktop.

cristianberneanu avatar cristianberneanu commented on July 28, 2024

This seems settled (at least for now).

from desktop.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.