Not working on Lumen 6.3.5 about lumen-cors HOT 6 CLOSED

For what it's worth, I just triggered a new CI build, and that passed with Lumen 6.3.5:

• https://travis-ci.org/github/digiaonline/lumen-cors/jobs/666313236#L353

The previous build was with 6.2.0 and passed:

• https://travis-ci.org/github/digiaonline/lumen-cors/jobs/626661470#L332

(I've turned on a monthly cron for the CI to help catch any failures from new releases.)

from lumen-cors.

@hugovk Thanks for that. We at least know that the tests are passing and looks like code coverage is good on the methods.

I can try and figure out what the deal is with my particular setup then and will report back of anything that is note worthy.

from lumen-cors.

Hard to tell without more information. You can add a die("foo") statement to the middleware to see if it's being run at all. If you have a debugger you can just set a breakpoint instead.

from lumen-cors.

Can you not reproduce the issue that i describe above ? It seems that i'm doing everything on my end correctly if it appears to work on Lumen 5.8 but not Lumen 6.3.5 ?

If you can not reproduce the issue, I have no problems digging deeper into my setup and trying to figure out why my setup is different than yours.

from lumen-cors.

@poppabear8883 is this still an issue?

from lumen-cors.

This appears to have been an issue on my end. I'll close this issue.

from lumen-cors.