Add .close() method about osm-p2p-db HOT 6 CLOSED

Hi @danielfdsilva,

If you're using osm-p2p-db (as opposed to osm-p2p - a simple wrapper) then you have control of the db instances you pass to the constructor, namely the hyperlog, the leveldb for join indexes, and the abstract-chunk-store (used for the kdb spatial index).

Each of these stores has a close() method usually, that takes a callback. You basically need to close each one yourself. It would result in problems trying to do this in osm-p2p-db because you control the data stores that are passed to osm-p2p-db and they could vary with their methods for closing.

This should be documented better somewhere, and I don't know if their is a better solution.

from osm-p2p-db.

This makes me realize that osm-p2p really ought to have a close() method.

from osm-p2p-db.

@gmaclennan
I'm actually using osm-p2p, since it prepares all the databases needed to work with osm-p2p-server.

I tried to access the different databases from the instance returned by osm-p2p, but I still get the LOCK error. I'm pretty sure I'm missing some.

I've tried:

db.db.close()
db.log.db.close()
db.kdb.db.close()

Any pointers at which I should be targeting?

from osm-p2p-db.

Run .close() on:

• db.db
• db.log.db
• db.kdb.kdb.store

(Fun caveat: db.kdb.kdb doesn't exist at creation time; you need to wait a few ticks for it to silently set itself up async in the background.)

Looking at how much source code digging was necessary in order for me to figure that out, it seems a bit unreasonable that osm-p2p and osm-p2p-db don't expose close() methods.

from osm-p2p-db.

@noffle That seems to have done it! thanks :)

from osm-p2p-db.

Fixed in 4.2.0 🎉

from osm-p2p-db.