Giter VIP home page Giter VIP logo

Comments (2)

GoogleCodeExporter avatar GoogleCodeExporter commented on September 26, 2024
I think it is correct as written.  machgen has type:
  struct _ServiceMachgen
  {
    ProtobufCService base;
    void *service;
  };
where 'service' is the generated service method table.  Basically, it's type is 
an
array of GenericHandler (the array is represented with GenericHandler*).

If we took a reference, then handlers[0] would be "service" itself, not a 
function
pointer, and your program will crash when it invokes that.

(At the moment, this code is untested, so there may be some bugs... but i don't 
think
this is one)

Original comment by [email protected] on 19 Jan 2009 at 3:32

  • Changed state: Invalid

from protobuf-c.

GoogleCodeExporter avatar GoogleCodeExporter commented on September 26, 2024
i was wrong.  your suggestion is correct, but I will commit something slightly
different... namely, I will get rid of ServiceMachgen altogether and use:

  handlers = (GenericHandler *) (service + 1);

(It turns out that there was another related bug a few lines down too: invoking 
the
handler with machgen->service wasn't right..)

This is committed to subversion, will be in 0.8 release, whenever that happens.

Original comment by [email protected] on 19 Jan 2009 at 3:45

  • Changed state: Fixed

from protobuf-c.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.