Comments (2)
I think it is correct as written. machgen has type:
struct _ServiceMachgen
{
ProtobufCService base;
void *service;
};
where 'service' is the generated service method table. Basically, it's type is
an
array of GenericHandler (the array is represented with GenericHandler*).
If we took a reference, then handlers[0] would be "service" itself, not a
function
pointer, and your program will crash when it invokes that.
(At the moment, this code is untested, so there may be some bugs... but i don't
think
this is one)
Original comment by [email protected]
on 19 Jan 2009 at 3:32
- Changed state: Invalid
from protobuf-c.
i was wrong. your suggestion is correct, but I will commit something slightly
different... namely, I will get rid of ServiceMachgen altogether and use:
handlers = (GenericHandler *) (service + 1);
(It turns out that there was another related bug a few lines down too: invoking
the
handler with machgen->service wasn't right..)
This is committed to subversion, will be in 0.8 release, whenever that happens.
Original comment by [email protected]
on 19 Jan 2009 at 3:45
- Changed state: Fixed
from protobuf-c.
Related Issues (20)
- protobuf-c requires AF_LOCAL
- protobuf-c does not compile on Solaris 10, as bind/connect/etc. are in libsocket
- Does not compile on Solaris 10, hstrerror in libresolv
- Don't include names to save space [patch]
- The last version cann't support string now? HOT 2
- VS 2008 compilation issue 0.15 HOT 1
- AF_LOCAL does not exists on Solaris, AIX and HPUX HOT 1
- Choose a build system, and get rid of the unchosen one
- compilation error HOT 3
- autoreconf 2.68 warnings
- optional missing in sub-message HOT 1
- unpack don't merge sub-messages
- giving static ip address to protobuf-c rpc server
- protobuf-c does not compile on 64bit Solaris 11
- structure with 64-bit field is decoded wrong
- ByteSize() doesn't return right value
- protobuf-c build with vc6
- free(): invalid next size (fast) at google/protobuf-c/protobuf-c.c:127
- C++: add a sub-element to a repeated element
- Reopening issue #38.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from protobuf-c.