do-agent --collector.<name> flags are confusing about do-agent HOT 10 OPEN

I'm facing the same issue.

I think the help string containing (default: true) are coming from node_exporter's kingpin flags themselves: https://github.com/prometheus/node_exporter/blob/v1.0.1/collector/collector.go#L67

meanwhile, in do-agent, various collectors are disabled by default as pointed out above:

in practice, what this ends up doing is adding --no-collector.arp etc to do-agent's internal cli flag set:

and then any subsequent --collector.arp flag is interpreted after that

the exact same issue would occur if running node_exporter directly, fwiw.

# ./node_exporter-1.1.2.linux-amd64/node_exporter --no-collector.arp --collector.arp
node_exporter: error: flag 'collector.arp' cannot be repeated, try --help

in config.go's disableCollectors you could do kingpin.CommandLine.GetFlag(fmt.Sprintf("collector.%s", name)).Default("false"), and then remove the os.Argv modification, but it won't help with the help strings

from do-agent.

This issue is somewhat related to #52 too.

from do-agent.

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs.

from do-agent.

This issue is not stale and has not received a response from Digital Ocean in 3 months.

from do-agent.

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs.

from do-agent.

still valid

from do-agent.

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs.

from do-agent.

Issue not stale yet, just a bit older.

from do-agent.

still valid

from do-agent.

I'm facing the same issue

from do-agent.