Giter VIP home page Giter VIP logo

Comments (5)

jjxtra avatar jjxtra commented on August 22, 2024

Not needed, the orderId param can be ORDERID,SYMBOLID. Binance is the only API with this crappy behavior, don't want to add this param for other API.

from exchangesharp.

wukan1986 avatar wukan1986 commented on August 22, 2024

the Okex is same as Binance, must use symbol.
maybe some exchange different symbol will get same orderId.

for example ,the https://github.com/ccxt/ccxt
def fetch_order(self, id, symbol=None, params={}):

from exchangesharp.

jjxtra avatar jjxtra commented on August 22, 2024

Hmmm, ok I wish the exchanges did not do this, seems like very poor design. They must be re-using order id for each symbol. This is a breaking change for Binance, but we will have to deal with that. Let's add the symbol parameter. As long as it defaults to null, should be fine. Can you do a pull request for Binance and Okex?

from exchangesharp.

wukan1986 avatar wukan1986 commented on August 22, 2024

OK, i will do it

from exchangesharp.

jjxtra avatar jjxtra commented on August 22, 2024

This has been merged in.

from exchangesharp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.