Comments (5)
Not needed, the orderId param can be ORDERID,SYMBOLID. Binance is the only API with this crappy behavior, don't want to add this param for other API.
from exchangesharp.
the Okex is same as Binance, must use symbol.
maybe some exchange different symbol will get same orderId.
for example ,the https://github.com/ccxt/ccxt
def fetch_order(self, id, symbol=None, params={}):
from exchangesharp.
Hmmm, ok I wish the exchanges did not do this, seems like very poor design. They must be re-using order id for each symbol. This is a breaking change for Binance, but we will have to deal with that. Let's add the symbol parameter. As long as it defaults to null, should be fine. Can you do a pull request for Binance and Okex?
from exchangesharp.
OK, i will do it
from exchangesharp.
This has been merged in.
from exchangesharp.
Related Issues (20)
- Bitfinex don't submit Stop order at margin account HOT 1
- Bitfinex don't submit order to tickers with special character ':' HOT 1
- Bitfinex don't submit market order without price (or price = zero) HOT 2
- How do i get the lastest master's repo version w/ nuget? HOT 2
- ExchangeOrderRequest.Price is this the grand total price or price for one coin HOT 2
- How to ensure that I am using a Market Order (to be executed immediately) HOT 2
- OrderBook Websocket: wrong break condition ? HOT 3
- GetAmountsAsync crashes program HOT 2
- URL to long on candle socket HOT 2
- CryptoUtility.ToDateTimeInvariant throws exception when Korea Standard Time is passed.
- Binance's methods that have a symbol parameter throw an error.
- LBank Invalid signature "error_code": 10007
- how to set a stop loss in binance HOT 1
- Kraken Get ticker failing HOT 3
- Binance OnGetTickersAsync throws InvalidDataException HOT 2
- GetTickersAsync failes for Binance HOT 15
- bittrex websocket stuck on connect
- Fail to create order: Param validation for 'symbol' failed on the 'symbol' tag HOT 1
- Need help Poloniex signature generation HOT 4
- Crashes when getting lots of data from Binance HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from exchangesharp.