Comments (2)
If await this.createDbConnection(dbType, config) will throw new DatabaseError('Failed to connect to Database') then I think the code will end up with unhandled promise rejection. Doesn't it?
from be-pkg-db.
@Romick2005 this error will be added to tasks but it is so unclear... that's why I'd propose to rewrite it in obvious way
from be-pkg-db.
Related Issues (7)
- Тести не працюють
- Fs sync access is not a good solution for asyn runtime HOT 1
- Database-related code coupled with HTTP
- Respect GRASP Information expert principle
- Decompose and error handling due to Single responsibility principle HOT 1
- Unneeded dependencies for fs recursion: rimraf, recursive-readdir
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from be-pkg-db.