GH Pages problem? about donut HOT 4 CLOSED

Now that I think of it, this doesn’t look right at all:

<script type="text/javascript" src="/static/js/bundle.js"></script></body>

The tool has been generating HTML with hashed filenames (e.g. /static/js/main.1223cbe1.js) since the very first version. Did you create that HTML file manually?

When you run npm run build with homepage set, you should see these instructions:

What you deployed seems like development bundle which is unoptimized.

What you should have deployed is the contents of the build folder, like described in the instructions. This is why it didn’t work.

We added a new message to help clarify this, which will be visible in the next version:

Do you think this helps convey the message that index.html and static/js/bundle.js from dev server should not be deployed directly?

from donut.

hey @gaearon!

• first of, all, amazing that you took the time to debug this. thanks.
• "we could have resolved this without ejecting". absolutely. ejecting is only a temp fix. i planned on diagnosing the issue further and reporting out on it, but exhausted my small timebox. we intend to revert our eject commit(s). We tagged all eject related commits with a🔧 emoji, and thus intended to rebase + drop them once we solved the problem!
• this history issue is most likely our problem. thank you! it was right there in the README. we will patch shortly.
• the current deployment, as you observed, is incorrect. it is a product of my incomplete troubleshooting. please disregard its known naughty, not-per-the-instructions state.
  • your messages & warnings are top notch--i violated them intentionally thinking that a webpack plugin may have been at fault for not rendering my content.
• lastly, unrelated, VisualBasic was great. I'm glad you gave it props in that nodeup podcast a ways back. I finally got around to listening and was happy to hear your defense of VB, as I have ~= the same story.

thx again. we will report back and close the issue out when work resumes on this project later in the week.

from donut.

👍 Please let me know if you have any issues in the future!

from donut.

that did the trick. thanks @gaearon!

from donut.