Giter VIP home page Giter VIP logo

Comments (4)

CDDelta avatar CDDelta commented on July 24, 2024 1

In 1.0 and many other implementations of AES-GCM, the MAC is concatenated to the end of the cipher text. This is what I do:

import 'package:cryptography/cryptography.dart';

final sha256 = Sha256();

/// Returns a [SecretBox] that is compatible with our past use of AES-GCM where the cipher text
/// was appended with the MAC and the nonce was stored separately.
SecretBox secretBoxFromDataWithMacConcatenation(
  Uint8List data, {
  int macByteLength = 16,
  Uint8List nonce,
}) =>
    SecretBox(
      Uint8List.sublistView(data, 0, data.lengthInBytes - macByteLength),
      mac: Mac(Uint8List.sublistView(data, data.lengthInBytes - macByteLength)),
      nonce: nonce,
    );

It would be nice if this were integrated into the package though or even the default as it is a rather common pattern.

from cryptography.

gpeal avatar gpeal commented on July 24, 2024

@CDDelta Aha! This worked! Thank you so much. Adding this to the docs would be extremely helpful! Another typo in the docs is that decrypt calls encrypt instead of decrypt
image

from cryptography.

maltemedocs avatar maltemedocs commented on July 24, 2024

Without this fix, the new API breaks compatibility with encrypted data created with prior versions of this library. That seems like a big issue to me, possibly leading to errors when the workaround is applied incorrectly, and definitely making it harder to use this package. Are there no plans to address this highly severe issue?

from cryptography.

DanielSoCra avatar DanielSoCra commented on July 24, 2024

Why is this issue closed? The documentation is still not fixed, and the issue still exists.

from cryptography.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.