Giter VIP home page Giter VIP logo

Comments (4)

direc85 avatar direc85 commented on July 25, 2024 1

Thanks for the report. I was actually planning to open this myself, this was already mentioned in issue #4

The issue is QChart.js, which doesn't offer a method to highlight a bar easily, so the options are patching QChart.js or reimplementing it. After seeing the performance boost my radar view rewrite had, I'm going to implement similar graph drawing method in QML.

from harbour-gpsinfo.

Olf0 avatar Olf0 commented on July 25, 2024

Thanks for the prompt and positive reply.

A second thought

Actually outlining the bars was a bad idea:

  • The outlines at the sides of the bar need additional horizontal space, thus reducing the width of the coloured part of the bars.
  • Outlines at the sides of the bars create the corner case of two adjacent bars being outlined: A double width outline might look ugly and occupies even more horizontal space.
  • An outline at the bottom of the bars is simply superfluous and may look weird.

So I think the top of the bars is the right spot to position an "in use" indicator.
Maybe a simple white "top line" is sufficient to achieve this easily.

from harbour-gpsinfo.

sbridger avatar sbridger commented on July 25, 2024

I have implemented this by changing bar colour: All active bars are the rssi color (like now) . inactive bars are all the same scale draw color.
I tried to use border color, width and label color, but they do nothing. Chart does appear to put fine lines in the grid color around the bars (visible when you make the bar color "transparent")

I have been wasting time after finding that when I delete your gpsinfo install, my version doesn't run because Chart is unknown. I have just found that pulling gpsinfo from GH does make the chart folder, but does not get any of the files inside it. However none of it is part of the project file, so I have no idea where Chart came from.

Do you need to add QChart to the project file?

from harbour-gpsinfo.

direc85 avatar direc85 commented on July 25, 2024

This is now "implemented-enough" in an already released version, so this can be closed. I'm still going to rewrite the barchart page to do without the external chart element - much like what I did to the radar page - but it's outside this issue.

Closing as fixed :)

from harbour-gpsinfo.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.