Comments (8)
Any chance of this being looked into again? I understand @doomb0t 's point completely, that it is implied we are expected to manage this, but it would be good to know for certain. Especially as there are 3 PRs open that could fix this and close issue 92 as well as this one. If it isn't, I guess are we expected to fork and include changes in our forks?
from discogs_client.
@brephophagist bump. Seems I am not the only one requesting it. Two recent threads started in the discogs api forum asking for the same thing. Here and here.
from discogs_client.
Thanks for mentioning it here @alifhughes. Little update on this one: https://www.discogs.com/forum/thread/818998
from discogs_client.
I second this. Looking at the code, it seems that the client doesn't honour the limits at all...
It would be great to have limiter based on X-Discogs-Ratelimit headers...
from discogs_client.
I can't find a place in the code that even returns the ratelimit headers. Hopefully I'm just not looking in the right place. But if they really aren't accessible from the python library, that renders the library almost useless.
from discogs_client.
Well, that's too harsh ;) I find the library very useful, although not finished. I'm currently working on the rate-limiting, but I'm still not sure what should the best strategy be.
The bigger problem seems to be inactivity of its developers, but I hope that's just temporary ;)
from discogs_client.
This may not be prioritized because it is documented what the limits values are so your application layer can account for this (ie take a timestamp at time of first request and make sure for the next minute the limit isn't reached) and, while it would not be the hardest change to make it would involve altering some of the wrapper behavior, which may require a fair amount of work to avoid issues with the tests etc. Because of this the developers may not see this as a bug report but a feature request, and it seems that new features aren't a priority for the client.
from discogs_client.
Hi, thank you for opening this issue.
Unfortunately, this project is no longer actively maintained, and today, we're archiving the repository and publishing the final version to PyPI.
We sincerely appreciate your contribution and regret that we weren't able to give it the attention it deserved.
from discogs_client.
Related Issues (20)
- master error when using discog HOT 2
- anaconda python 3.7 comptability HOT 1
- Neither of the authorization scemes work. HOT 3
- incorrect tracklist for versions with more than one side CD HOT 5
- Some albums not found in the database HOT 2
- "type_" missing from Track HOT 1
- Add sort to search function HOT 1
- Production Credits HOT 2
- Client' object has no attribute 'Release' HOT 3
- Unable to set order shipping price HOT 1
- -
- Increase test coverage for network request fetchers HOT 1
- Release CatNo HOT 2
- Rate limit, how to get remaining? HOT 2
- Exclude appearances HOT 1
- Any way to get a release's exact release date? HOT 3
- Accept header HOT 2
- What is one request? HOT 4
- Image is broken when its a gif HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from discogs_client.