Comments (6)
Thanks for reporting this issue.
I think a reasonable solution to this is to have Seq.empty
stop the creation of the =
. I'd argue this is the behavior one would expect, anyway, so we don't need a major version bump to indicate a breaking change. I'll see what I can do about fixing that up this weekend when I have some FOSS time.
from reboot.
Okay, @hbergmey, I've dug into this a bit. As a work-around you might consider using our addQueryParameter
variant and providing a null
to it. That should avoid the NullPointerException of the setQueryParameters
currently experiences when you pass null
.
I think what we'll ned to do is add a variant of addQueryParameter
that takes an Option
and rework how setQueryParameters
works internally.
from reboot.
Classifying this as an improvement, not a bug. I think the nature of the previous behavior, while unexpected, isn't something I'm comfortable in back-porting to a previous release even though I am comfortable changing that behavior as a non-API-breaking change in a minor point release. This will ship with 1.2.0, accordingly.
from reboot.
An alternative would be an explicit model of different parameter types, like key value pairs and single expressions. But that would result in a bigger API change. I think an Option
is reasonable.
I am going to try addQueryParameter
with null
value until then.
from reboot.
Thank you very much for solving this, over the holidays even. I was OOO until today and have just tested the API request with a local 1.2.0-SNAPHOT build and a Seq.empty value. It works as expected now.
May I kindly ask, whether the 1.2.0 release is already anywhere on the horizon? I will have to use this in production soon and I am unsure how much risk there is in employing a locally build SNAPSHOT. Especially because I have to upgrade from 1.0.1. As far as I can tell from the git log and release notes, I do not expect all too much trouble, because the APIs I am accessing work with UTF-8, not UTF-16 and I am decoding JSON with Circe, but I'd rather be sure to not miss anything.
from reboot.
I can go ahead and release it this week.
from reboot.
Related Issues (20)
- Updating from 0.8 to 0.13 HOT 5
- Upgrade lift-json module for Lift 3.1.0
- Provide plain-english alternatives to every method in the symbolic DSL
- Bump to AHC to 2.0.33
- Possible domain / group id change HOT 4
- Implement implicit vs explicit verb setting
- Cross-build / abstract against AHC HOT 1
- Investigate different thread allocation semantics under the hood
- Please publish a version for Scala 2.13.0-RC1 HOT 15
- sbt eviction notice HOT 1
- Incorrect UriEncoding of emoji characters HOT 1
- setting request body with << changes method from PUT to POST HOT 6
- Emoji character in domains not recognized correctly (punycode) HOT 1
- Emoji character in domains not recognized correctly (punycode) HOT 8
- Rename primary branch HOT 1
- Add support for Scala 2.13 HOT 1
- Add support for Dotty HOT 5
- Update scala-xml dependency to version 2
- Set up dependency update for this repository
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reboot.