Requesting URLs with custom parameters is not possible about reboot HOT 6 CLOSED

Thanks for reporting this issue.

I think a reasonable solution to this is to have Seq.empty stop the creation of the =. I'd argue this is the behavior one would expect, anyway, so we don't need a major version bump to indicate a breaking change. I'll see what I can do about fixing that up this weekend when I have some FOSS time.

from reboot.

Okay, @hbergmey, I've dug into this a bit. As a work-around you might consider using our addQueryParameter variant and providing a null to it. That should avoid the NullPointerException of the setQueryParameters currently experiences when you pass null.

I think what we'll ned to do is add a variant of addQueryParameter that takes an Option and rework how setQueryParameters works internally.

from reboot.

Classifying this as an improvement, not a bug. I think the nature of the previous behavior, while unexpected, isn't something I'm comfortable in back-porting to a previous release even though I am comfortable changing that behavior as a non-API-breaking change in a minor point release. This will ship with 1.2.0, accordingly.

from reboot.

An alternative would be an explicit model of different parameter types, like key value pairs and single expressions. But that would result in a bigger API change. I think an Option is reasonable.

I am going to try addQueryParameter with null value until then.

from reboot.

Thank you very much for solving this, over the holidays even. I was OOO until today and have just tested the API request with a local 1.2.0-SNAPHOT build and a Seq.empty value. It works as expected now.

May I kindly ask, whether the 1.2.0 release is already anywhere on the horizon? I will have to use this in production soon and I am unsure how much risk there is in employing a locally build SNAPSHOT. Especially because I have to upgrade from 1.0.1. As far as I can tell from the git log and release notes, I do not expect all too much trouble, because the APIs I am accessing work with UTF-8, not UTF-16 and I am decoding JSON with Circe, but I'd rather be sure to not miss anything.

from reboot.

I can go ahead and release it this week.

from reboot.