Giter VIP home page Giter VIP logo

Comments (2)

jonaskello avatar jonaskello commented on July 19, 2024

Since we potentially want to move all the registries with global mutable state out of this package, it might be a good idea to keep symbol as-is on BaseUnit and AlternativeUnit and also keep the buildDerivedName function this package and export it for external use (it is a pure function that is not dependent on the registry). The function should be renamed to buildDerivedLabel or buildDerivedSymbol where the latter seems more logical since it uses the symbol field from the BaseUnit to build the result.

from uom.

jonaskello avatar jonaskello commented on July 19, 2024

Since buildDerivedName is a pure function with only Unit as input it makes sense to move that function to the unit.ts module and export it from there (and also rename it to buildDerivedSymbol).

from uom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.