Bug - Namelist in wrong order for JIP about diwako_dui HOT 10 CLOSED

Since this is the first report with name list being out of order, I assume it has something to do with BIS dynamic groups. I personally do not use it, nor do the groups I play in. So it never really came up.

So, I'd need some help reproducing the bug and debugging it. Maybe the bug comes up even without the Dynamic Group feature, not sure. It take multiple people to debug this sadly.

from diwako_dui.

https://github.com/gruppe-adler/gruppe_adler_mod ; groups-related code is in https://github.com/gruppe-adler/gruppe_adler_mod/tree/master/addons/dynGroups

from diwako_dui.

That gruppe adler mod component just modifies BI's dynamic group system slightly, shouldn't be relevant here.

The mission template that was used can be found here:

https://github.com/gruppe-adler/CO_Template.VR

See my last reply for the relevant code (\functions\groupsettings).

from diwako_dui.

Can confirm.

from diwako_dui.

Hm, first I heard of this.

@McDiod @AdlerXiviD Any specific way to replicate this?

from diwako_dui.

We haven't tried yet. The way this happened yesterday was:

1. group of four players, mission starts
2. one player disconnects
3. FTL assigns buddy teams
4. disconnected player reconnects on the same slot
5. reconnected player sees namelist in a different order

We are using BI's dynamic group system. The groups callsign is set during postInit by a third script. Either that has something to do with it, or the units group array is unreliable during postInit? Maybe some units are still null during initialization, so your cache loop skips them first, then adds them later resulting in a different order.

Edit: Server sets the groups callsign when registering the group in the dynamic group system:

_callsign = [_x] call grad_groupsettings_fnc_getCallsign;
_leader = leader _x;
_data = [nil, _callsign, false];
["RegisterGroup", [_x, _leader, _data]] call BIS_fnc_dynamicGroups;

from diwako_dui.

The cache loop grabs the units using units group _player each half a second meaning it is using the what ever the game gives back. Units being objNull is pretty much a none issue.

What would be interesting would be in which order these are returned and what internal names these units get assigned on each machine.

E.g.
Bravo 1-3:1 or the like or by assigning an empty string as vehicleName

Meaning it might be possible to sort by the internal name to sync things for everyone.

Here a small script for the debug console to get the current squad members internal names, (be aware this will remove any sort of display variable name given to them)

private _grp = units group ace_player;
{
  _x setVehicleVarName "";
} forEach _grp;

_grp

from diwako_dui.

I am not too familiar with gruppe Adlers mods (besides trenches), would help if you could link me their GitHub repo for this (if it is openly available)
@McDiod

from diwako_dui.

Testing was done, findings were as follows

Replication

1. have two groups
2. someone disconnects from group A
3. Someone from group B joins the group
4. someone reconnects into group A

Resulting asynchronicity.

diwako's machine:
[B Alpha 1-2:1 (Diwako),B Alpha 1-2:2 (nomisum) REMOTE,B Alpha 1-2:3 (Salbei250) REMOTE,B Alpha 1-2:4 (McDiod) REMOTE]
McDiod's machine:
[B Alpha 1-2:1 (nomisum) REMOTE,B Alpha 1-2:2 (Diwako) REMOTE,B Alpha 1-2:3 (Salbei250) REMOTE,B Alpha 1-2:4 (McDiod)]

That basically means, it is NOT possible to sort them according to their internal squad names, as these are already out of sync.

This seems to be a BI bug. It could be ""fixed"" by recreating the group and giving its all the same values or by using one unit in the squad to share their order.
However that would mean DUI would not be a client side only addon anymore.

from diwako_dui.

PR was merged, preview is already on the dev workshop item. Closing this now, if you find anything lacking feel free to notify me

from diwako_dui.