Throw causes entire script to exit if selected blocks don't exist about rellax HOT 7 OPEN

@moeamaya Respectfully, I disagree with throwing an exception. Rellax is a nice to have and typically isn't required for the page to work so throwing an exception and stopping the entire script from executing doesn't make sense to me. Rellax should definitely not run if no elements exist, but I don't believe stopping other JS from running is right.

I think throwing a warning instead would be more appropriate.

from rellax.

@mattclough1 Can you instantiate rellax only on the pages you need?

from rellax.

@moeamaya yeah, I just went ahead and checked whether the element was available before instantiating... depending on how someone is using Rellax, an exception is probably appropriate. In my case it's embellishment. Disregard! 😅

from rellax.

Hey I know how it goes when you're trying to ship your site, so no worries.

I think i am going to keep the throw because I think it's best practice and breaking JS is maybe a feature in this case.

from rellax.

Similar issue without bundling

from rellax.

@KeironLowe How dare you say Rellax is "a nice to have" it's as critical as babel 😜

But okay I hear you all, and I recant my original position. If anyone wants to make a PR happy to merge without the blocking exception.

from rellax.

@moeamaya Some would say even more critical! Thanks, I've just submitted a PR.

from rellax.