Comments (5)
Do you mean you think we should put this back in?
00fe4ec
from django-localflavor.
Oh I didn't remember this. Do you remember why you removed isort?
from django-localflavor.
Too many contributors were having problems with it. I personally still like it but I thought making things a bit easier is more important than having sorted imports. The plan was to just run isort manually once in a while.
In my own projects use isort and black with pre-commit to run these tools. However, I get fewer contributors to these projects so it's less of an issue. In any case, I'm fine with turning the isort check on again if you think it's worthwhile.
from django-localflavor.
I have a love-hate relationship with auto-formatting tools, so feel free to close the ticket if you feel like it.
from django-localflavor.
I really like auto-formatting - especially when pre-commit is used. In this case, I think having a CI check for sorted imports will get in the way for less experienced contributors. I can just run isort manually once in a while. I'll make sure that I do this as a separate commit.
from django-localflavor.
Related Issues (20)
- Update Chile to have new region HOT 3
- 3.1 Release: 27 May 2021 HOT 7
- Field of CharField inheritance HOT 7
- Move from Travis CI to Github Actions for CI HOT 1
- Add support of models for Japan
- Bug: CIF spanish starting with U does not validate HOT 5
- French local : Use class Validators for SIRET and SIREN model fields, do not format output HOT 2
- Upgrade to Django 4.0 HOT 3
- localflavor fields not showing up HOT 1
- Add support for Nepal
- 4.0 release HOT 9
- IBAN validator failed for Italy HOT 3
- Override formfield method on Brazilian Model Fields HOT 2
- Add local-flavor support for Sri Lanka HOT 1
- Japanese translations are not supported HOT 9
- Javascript Support?
- Should `ISO_3166_1_ALPHA2_COUNTRY_CODES` be in `choices` format instead of as a flat tuple?
- Update Python and Django versions HOT 1
- Accept French Postal Services identifiers in forms
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from django-localflavor.