Giter VIP home page Giter VIP logo

Comments (5)

benkonrath avatar benkonrath commented on June 9, 2024

Do you mean you think we should put this back in?
00fe4ec

from django-localflavor.

claudep avatar claudep commented on June 9, 2024

Oh I didn't remember this. Do you remember why you removed isort?

from django-localflavor.

benkonrath avatar benkonrath commented on June 9, 2024

Too many contributors were having problems with it. I personally still like it but I thought making things a bit easier is more important than having sorted imports. The plan was to just run isort manually once in a while.

In my own projects use isort and black with pre-commit to run these tools. However, I get fewer contributors to these projects so it's less of an issue. In any case, I'm fine with turning the isort check on again if you think it's worthwhile.

from django-localflavor.

claudep avatar claudep commented on June 9, 2024

I have a love-hate relationship with auto-formatting tools, so feel free to close the ticket if you feel like it.

from django-localflavor.

benkonrath avatar benkonrath commented on June 9, 2024

I really like auto-formatting - especially when pre-commit is used. In this case, I think having a CI check for sorted imports will get in the way for less experienced contributors. I can just run isort manually once in a while. I'll make sure that I do this as a separate commit.

from django-localflavor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.