Ergonomics issue with PostgresConnectionManager about bb8 HOT 2 OPEN

I wonder if this is really a bug with tokio-postgres. If it had an impl MakeTlsConnect for Box<dyn MakeTlsConnect>, then you could just box whatever you have into a trait object and things would work.

Any thoughts @sfackler?

from bb8.

Just want to pile on here to say I'm having the same issue -- in fact I'm trying to store the connection manager and the pool that gets created. At first I tried to use the code that @ufoscout wrote in sfackler/r2d2-postgres#19, but I didn't want to stray that far from the beaten path so I ended up with this monstrosity:

type ConnMgr = PostgresConnectionManager<Box<dyn MakeTlsConnect<Socket, TlsConnect=dyn Send, Stream=dyn Send, Error=dyn Error>>>;

Now I'm just running into the same problem with Pool<M> where M is something that implements ManageConnection, and I'm struggling on how to fill the Connection and Error type variables. While I'm sure this really cleaned up the code for r2d2 it's made it a lot harder to use. Haven't been able to figure out how to do it for Pool so now I've moved making the pool to the area before I loop forever handling requests (it's a bit of an "actor"-ish setup).

[EDIT] - In the end I just stopped trying to own both of those in my own setup. This has made it really difficult to use -- implementing MakeTlsConnect for Box<dyn MakeTlsConnect> would definitely solve this it looks like though, since that's exactly what I"m missing -- is that OK as a path forward?

from bb8.