[mu4e bug] `mu4e-compose-reply` opens buffer twice about mu HOT 4 CLOSED

Hmm... I think the advice-code was a mistake, and as you've noticed it's rather error-prone for mu4e to have such code-paths since I won't notice any problem until it's too late.

I see two ways:

• somehow ensure that message-pop-to-buffer honors display-alist / display-buffer
• if that's not (yet) possible, document the add-advice;

Looking at the current implementation, it seems message-pop-to-buffer does support a switch-function (and I guess display-buffer could be used for that)... but we don't control how various function call message-pop-to-buffer. So perhaps lobby the Gnus people to make this configurable, don't think I want mu4e trying to hack around that.

Or perhaps I'm totally wrong and am overlooking some simple solution :)

from mu.

Maybe a slightly less brittle option would be to cl-letf message-pop-to-buffer to mu4e--fake-pop-to-buffer?

(cl-letf (((symbol-function 'message-pop-to-buffer) mu4e--fake-pop-to-buffer))           

from mu.

Yeah, that's indeed slightly less brittle, but the add-advice has the advantage that it can be set outside mu4e.

from mu.

Anyway, I brought back mu4e--fake-pop-to-buffer, since all the other non-default mu4e-compose-switch such frame and window also had problems without. Guess we'll have to live with it...

from mu.