[mu4e bug] mu4e-compose-pre-hook is broken in v1.12+ about mu HOT 4 CLOSED

That's indeed broken, I fixed it a some point.. but apparently it broke again :-|

Also thank you for the PR... I'm pushing a change that is slightly different, running the hook a bit earlier so that (as the docstring suggests) one could influence the later draft-creation steps.

from mu.

Good to know. If you need I’m willing to test it :)

from mu.

I just checked your implementation and it’s far more simple and better than mine.

It leverages just a little thing: maybe you should also run the cl-assert from the mu4e--prepare-draft-buffer before even running the hooks? The idea being to fail sooner if the message-type or parent variables are not valid?

I’m speaking about these lines:

  (cl-assert (member compose-type '(reply forward edit new)))
  (cl-assert (eq (if parent t nil)
                 (if (member compose-type '(reply forward)) t nil)))

from mu.

Maybe we could copy them to the being of mu4e--draft, but tbh, these assert are more-or-less leftovers from development, so don't care too much about them.

Anyway, thanks for the heads up! Closing this ticket.

from mu.