DCD does not show UFCS completions about dcd HOT 14 OPEN

What about this:

• no UFCS completion after dot
• UFCS completion activated only if current identifier is at least N characters long.

import std.ascii;
char c;
c. // no UFCS completion so just the type properties.
c.is // no UFCS completion, not enough chars (3 required).
c.isA // 3 chars, ok, isAlpha and isAlphaNumeric proposed.

from dcd.

A potential idea to filter out false positives would be to infer valid UFCS functions from existing usage. For instance, if DCD sees that frobify is called via UFCS in existing code with variables of type Foo, it can suggest it as a completion candidate after . when it knows the preceding expression has type Foo.

This would also help with making the suggestions take into account stylistic / semantic aspects. For instance, if the user always writes format("...", ...args...) but never "...".format(...args...), then they probably don't want to see the latter as a suggestion candidate.

from dcd.

I made some progress on the subject. You may check it here SSoulaimane/dcd@dc66681.
lookup, documentation, calltip... everything works perfect, except for identifiers completion. the list of matches is bloated with false positives, because I only check if the function/struct/... takes at leat one argument. no type-checking is done, dsymbol is not yet ready for that.
I don't know whether to make a pull request yet. for one every identifiers completion test is broken because new symbols were introduced. second I'm not satisfied with results just yet.

from dcd.

What would it take to start supporting this?

We could always start with the easier non-templated-first-parameter case.

This is by far the largest usability improvement I can think of.

If you just point out the places in the code where to add this logic I'd be very happy to help out and start working on a PR for this.

Further I would like the lookup of function definitions to work with UFCS aswell. Is there another place where this logic is defined?

I'm using the Emacs interface ac-dcd to interact with DCD.

from dcd.

If it was as simple as pointing out a single place in the code where the logic should be added, it would have been added already. I have a few ideas on how this can be implemented and I'll work on adding it for the 0.6.0 release.

from dcd.

Pulling this from 0.6.0.

from dcd.

Any ideas on how to move forward with this?

from dcd.

I'd be happy with that.

from dcd.

Being able to just go to definiton of the function at cursor in a UFCS-call would be an amazing progress. Especially when navigating codebases such as dmd. If there are multiple overloads in multiple scopes just propose a list to choose from.

Can we pleease be pragmatic and add this? It would be a great productivity enhancement.

from dcd.

Any update here?

from dcd.

Any update here?

#657 works partially for me. I don't think it's that difficult get it all the way. I have little time over right now, though.

from dcd.

Why not add this feature?

from dcd.

Why not add this feature?

It's a bit of work completing #657.

from dcd.

I am also very interested in this feature. I think a lot of people are using UFCS, it would be very helpful to be able to navigate to the correct file where the function is defined.

from dcd.