Giter VIP home page Giter VIP logo

Comments (9)

MartinNowak avatar MartinNowak commented on August 18, 2024

Not really IMO, remember that we don't rebuild pending PRs when master changes, because it's O(NĀ² / 2). To still catch bugs that are caused by semantic differences (not textural ones which would cause merge conflicts), the integration branch needs to be retested.
This could indeed be done less often, e.g. daily, because the chances are low and a bit of bisecting add much complexity.

from ci.

MartinNowak avatar MartinNowak commented on August 18, 2024

Same goes for AppVeyor and SemaphoreCI, let's please find a common policy for all of those.

from ci.

wilzbach avatar wilzbach commented on August 18, 2024

It doesn't help anyone if no one looks at the errors which is the case at the moment.

from ci.

MartinNowak avatar MartinNowak commented on August 18, 2024

Yes, those would need a badge or sth. to be more visible, but someone will notice it eventually already.

from ci.

MartinNowak avatar MartinNowak commented on August 18, 2024

Also E-Mail notifications would be appropriate for a broken master.

from ci.

wilzbach avatar wilzbach commented on August 18, 2024

I was the only one subscribed to these mails, but I can't fix everything. For CircleCi, everyone can click on subscribe on their platform to receive such mails, but still I was the only one caring and fixing this when there was a failure a couple of days ago at Phobos.
With AppVeyor there were also a couple of random failures in the beginning.

Yes, those would need a badge or sth. to be more visible, but someone will notice it eventually already.

Already there. Also these two CIs aren't mission critical and the free resources they offer are simply not enough to rebuild master on every PR. Daily builds are enabled though.

from ci.

wilzbach avatar wilzbach commented on August 18, 2024

Also with so much frequency on GitHub and every PR merging with master a failure would immediately be discovered, but I haven't seen one case where merging to master made a difference or lead to a failure. The failures are caused by other things.

from ci.

MartinNowak avatar MartinNowak commented on August 18, 2024

Yes, daily build would still help to catch the rare issues that mostly happen with major refactorings. Since Kenji no longer works on the compiler, those have indeed become extremely rare.

from ci.

wilzbach avatar wilzbach commented on August 18, 2024

On Buildkite we could in theory ignore building master ("Branch limiting") - https://buildkite.com/dlang/dmd/settings/repository

from ci.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.