Giter VIP home page Giter VIP logo

Comments (3)

dlikhten avatar dlikhten commented on August 23, 2024

I have been considering the usage of this library, and I believe the ideal solution would be to limit the API to the constructor only.

#reFilter will be used to re-execute a filter.
new ...(null, {collection: {}, filter: function() {}}) will be the way to set a collection and a filter, changing filters will be disabled as it would make much more sense to create another filtered collection along with it's appropriate filter and sub-collection

from filtered-collection.

dlikhten avatar dlikhten commented on August 23, 2024

I notice there are quite a few people using this tool. Is there any objections to this? This would be quite the API-breaker.

from filtered-collection.

musterknabe avatar musterknabe commented on August 23, 2024

So far I only used it to set the filter once and this would benefit from being able to add the filter function as a parameter in the constructor.

But just now I wanted to look up an API to add more filters to an already filtered collection. So something like addFilter() would be handy.

The API could be extended both ways without breaking changes i guess.

from filtered-collection.

Related Issues (13)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.