Comments (3)
I have been considering the usage of this library, and I believe the ideal solution would be to limit the API to the constructor only.
#reFilter
will be used to re-execute a filter.
new ...(null, {collection: {}, filter: function() {}})
will be the way to set a collection and a filter, changing filters will be disabled as it would make much more sense to create another filtered collection along with it's appropriate filter and sub-collection
from filtered-collection.
I notice there are quite a few people using this tool. Is there any objections to this? This would be quite the API-breaker.
from filtered-collection.
So far I only used it to set the filter once and this would benefit from being able to add the filter function as a parameter in the constructor.
But just now I wanted to look up an API to add more filters to an already filtered collection. So something like addFilter() would be handy.
The API could be extended both ways without breaking changes i guess.
from filtered-collection.
Related Issues (13)
- Filtering should be efficient with add and remove events HOT 1
- Possible issue with inherited _onModelEvent HOT 8
- Adding an element to the filtered results gets tracked incorrectly HOT 1
- Need an event which signifies that filtering is complete HOT 1
- Adding version number HOT 3
- Convert to Gem HOT 1
- Better support for sort
- If underlying collection triggers any event we don't handle, re-trigger it. HOT 8
- add to Bower registry HOT 1
- Render my view collection before filter. HOT 2
- Create the first library version HOT 1
- Release 1.2.1 to rubygems HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from filtered-collection.