Giter VIP home page Giter VIP logo

Comments (4)

wkillerud avatar wkillerud commented on June 2, 2024 7

I've been experimenting with a solution here. I've tested it in a project that uses a custom importer, and with or without source maps, and with both Dart Sass and the new Embedded Sass. It looks like it's working fine, so I can open a pull request if you'd like.

The gist of it is to replace calls to render and renderSync with the new compileAsync and compile. That requires some adapting, particularly in filePush. It also means a breaking change, since the options API is changed.

I suppose a breaking change could be avoided by keeping the current code, and have the new API be opt-in somehow. Personally I'd opt to go for a breaking change sooner than later, since the legacy API is going to be removed in the next major version of Sass anyway, but that's up to you 😄

Let me know if I can help!

from gulp-sass.

wkillerud avatar wkillerud commented on June 2, 2024 3

I took the liberty of opening a PR @xzyfer

(sorry for the associated commit spam, I just noticed).

from gulp-sass.

xzyfer avatar xzyfer commented on June 2, 2024

This package is in maintenance mode. We aim to resolved security issues and general high priority maintenance. In this case we're open to pull requests as the existing dart-sass API appears to still be working.

from gulp-sass.

firefoxic avatar firefoxic commented on June 2, 2024

It seems with Sass v1.63.4 release js api worked in this plugin, or not? 🤔

from gulp-sass.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.