Giter VIP home page Giter VIP logo

Comments (6)

imsodin avatar imsodin commented on August 20, 2024 1

I got that, I just need to figure out what's wrong to produce a change that works in both cases - thanks for providing an example for that :)

I'll probably have a look at this next week.

from aislib.

dimitrispallas avatar dimitrispallas commented on August 20, 2024

We had a problem in our system parsing the messages with comment blocks that start with the \g: prefix. With that commit our problems has been resolved. Please feel free to apply a pull request in order to completely fix the issue! Thanks in advance!

from aislib.

imsodin avatar imsodin commented on August 20, 2024

Happy to contribute that, however I need to know what exactly was broken for you (I don't see anything obviously wrong with messages starting with \g:) - could you provide some test data that failed and what you'd expect from it (or a unit test)?

from aislib.

imsodin avatar imsodin commented on August 20, 2024

I just checked and the unit test that failed with the new version on my side is also a comment block starting with \g:, and it was working fine before. So I'll definitely need some example to reproduce your issue.

from aislib.

dimitrispallas avatar dimitrispallas commented on August 20, 2024

this is an actual message 24 with comment block that starts with \g:

\g:1-1-21,s:47450,c:1699113260,i:SXSPA:1699115144 I:1699115146 D:1699115146 L:FM136 G:hndgs T:0 1261!AIVDM,1,1,,A,H7Oks<0hTtpE=<0000000000000,24C

Beforehand our system wasn't able to decode and produce the JSON output for that kind of sentence. And we are parsing millions of them in a daily basis. As I already said currently everything works properly in comparison with the previous code.

from aislib.

imsodin avatar imsodin commented on August 20, 2024

Obviously that "next week" prediction didn't pan out xD.
It's basically in my backlog now, but given no-one else seems to be affected it anyway is hardly time-critical.

from aislib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.