Giter VIP home page Giter VIP logo

Comments (10)

DmitriySalnikov avatar DmitriySalnikov commented on June 18, 2024 1

Well obviously I am biased, but I wouldn't mind a bigger program. I think the memory footprint won't be an issue on a PC that's streaming anyway. So long as the performance is still good. The performance now seems excellent.

Yes, I agree. This is not a problem when one replay can take from 100MB and up to several GB.. I just don't like when a mini application with little functionality takes up a lot of space. Like, for example, most applications on electron.
Anyway, I'll think about different options. I want to fix the other issues first.

from obsnotifier.

 avatar commented on June 18, 2024 1

...And you got CI working, nice!

Works great, thanks mate!

Edit: I did notice this little typo 'settigns'
image

from obsnotifier.

 avatar commented on June 18, 2024 1

Works great! I see you also noticed the thing where it wouldn't open the first time, thanks for getting that one too :)
I had assumed that the flashing console screen was OBS launching the script, when in reality it was the script launching OBSNotifier. Sorry about that. It's much better now.

image
This was nice, too. All very smooth.

from obsnotifier.

DmitriySalnikov avatar DmitriySalnikov commented on June 18, 2024

Sounds good.
I can add a button to create this script in AppData, update it if necessary and show the user a hint on how to use it.

image

I'm migrating to linux soon, and I'm going to miss it already.

I've already thought about remaking this program on something cross-platform. But for example, using Avalonia, this program will become much larger, not 2MB, but 60MB+

from obsnotifier.

 avatar commented on June 18, 2024

Well obviously I am biased, but I wouldn't mind a bigger program. I think the memory footprint won't be an issue on a PC that's streaming anyway. So long as the performance is still good. The performance now seems excellent.

It would be great to have a button to create the script! Makes it much easier to install :)

Thanks mate!

from obsnotifier.

DmitriySalnikov avatar DmitriySalnikov commented on June 18, 2024

I started working on this feature, but I simplified the script a bit. Now there is no parameter for choosing the path to the program. This path is set when creating or updating the script by clicking in the OBS Notifier settings.

obs = obslua

function script_description()
	return [[Starts OBSNotifier when OBS starts]]
end

function script_defaults(settings)
	obs.obs_data_set_default_bool(settings, "lowprio", true)
end

function script_properties()
	local properties = obs.obs_properties_create()
	obs.obs_properties_add_bool(properties, "lowprio", "Run with lower priority")
	obs.obs_properties_apply_settings(properties, settings)
	return properties
end

function script_update(settings)
	lowprio = obs.obs_data_get_bool(settings, "lowprio")
	start_OBSNotifier(path, lowprio)
end

function start_OBSNotifier(path, lowprio)
	priostring = "/NORMAL"
	if (lowprio == true)
	then priostring = "/BELOWNORMAL"
	end
	StartCommand = "start /B /MIN " .. priostring .. " \"OBSNotifier\" \"&OBS_NOTIFIER_PATH&\" --force_close"
	obs.script_log(obs.LOG_INFO, "Executing command: " .. StartCommand)
	output = os.execute(StartCommand)
	obs.script_log(obs.LOG_INFO, "Output: " .. output)
end

I think it will be easier this way. The user will only need to specify the path to the script. Also, the path will be automatically copied to the clipboard after clicking on the button.

from obsnotifier.

 avatar commented on June 18, 2024

Now there is no parameter for choosing the path to the program. This path is set when creating or updating the script by clicking in the OBS Notifier settings. The user will only need to specify the path to the script. Also, the path will be automatically copied to the clipboard after clicking on the button.

Very smooth :)

from obsnotifier.

DmitriySalnikov avatar DmitriySalnikov commented on June 18, 2024

I seem to have completed the integration of the autostart script acd0250
Could you check if it works as intended? download an artifact

from obsnotifier.

DmitriySalnikov avatar DmitriySalnikov commented on June 18, 2024

Thanks!

from obsnotifier.

DmitriySalnikov avatar DmitriySalnikov commented on June 18, 2024

I did make more changes to the script 7561b2c 3c1e686
I didn't like that the console window appeared before opening OBS Notifier. Now WinAPI is used to open the program.

Now I think it's finished. (but maybe there are some bugs 🙂)

from obsnotifier.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.