Giter VIP home page Giter VIP logo

Comments (3)

bf4 avatar bf4 commented on June 25, 2024

Thanks @phinze for making this issue. Came here to see if there was anything after I couldn't see anything obvious in the changelog or diff.

For me, tests pass on 5aedf27
and fail on 1a8eb48

the current head ref for me is still broken

technically in my case it's in lib/store_model/types/many_base.rb

with the change

     def serialize(value)
        case value
        when Array
-          ActiveSupport::JSON.encode(value, serialize_unknown_attributes: true)
+          return ActiveSupport::JSON.encode(value) unless value.all? { |v| v.is_a?(StoreModel::Model) }
+
+          ActiveSupport::JSON.encode(value,
+                                     serialize_unknown_attributes: value.first.serialize_unknown_attributes?,
+                                     serialize_enums_using_as_json: value.first.serialize_enums_using_as_json?)

when value #=> [] is an empty array

from store_model.

bf4 avatar bf4 commented on June 25, 2024

Happened to get my head in the space and found the fix #176 Not sure about the test. Having trouble getting all tests to pass, but my new test passes 🤷

from store_model.

DmitryTsepelev avatar DmitryTsepelev commented on June 25, 2024

Thank you all for help! The first PR is merged and I'm gonna to merge a second one right now. Please reach out if something is off 🙂

from store_model.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.