Giter VIP home page Giter VIP logo

Comments (5)

DmitryTsepelev avatar DmitryTsepelev commented on May 24, 2024

Hi @rainerborene!

Thank you for the interest, give me a couple of days to try it with plain old Rails views - we're using this gem with the React client and pass all the attributes explicitly (which I assumes works as a workaround for your issue, but I believe we can fix assign_attributes too)

from store_model.

rainerborene avatar rainerborene commented on May 24, 2024

Hey @DmitryTsepelev. Thank you! One way would be to monkey patch assign_attributes to mimic the behavior of accepts_nested_attributes_for, or the gem could support the latter by treating like a normal association (not sure about that). I'll try to split params into multiple methods like data_params and post_params, and assign each one individually.

from store_model.

DmitryTsepelev avatar DmitryTsepelev commented on May 24, 2024

@rainerborene I've tried to create the classical Rails app with forms, and it feels like attribute works like the association (the only diff is that I had to add a value to <%= configuration_form.text_field :color, value: product.configuration.color %>), but it's not the association, it's just a hash :) I'm going to put it into the docs, the easiest workaround I see here is to add hidden field for each field that not used on the form (in other words - the form should send the whole hash always). Please let me know if this workaround solves your issue

from store_model.

rainerborene avatar rainerborene commented on May 24, 2024

@DmitryTsepelev I've decided to steal your proposed solution on this unmerged pull request #8, and adapted it without extending ActiveRecord.

# app/models/user.rb
def data=(value)
  super data.as_json.merge(value)
end

Now one more extra piece of code for cleaning up nil values from data column.

# app/models/data.rb
class Data
  include StoreModel::Model

  # ...

  def as_json(options = {})
    super.compact
  end
end

It's working like a charm!

from store_model.

DmitryTsepelev avatar DmitryTsepelev commented on May 24, 2024

Yeah that's definitely an option. I decided to not patch base class because I was not sure if it won't break anything. In your case it looks pretty safe

from store_model.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.