Definition of Business Knowlege Model return type is wrong for 22 test cases about tck HOT 8 CLOSED

@DanielThanner what you are pointing out matches my initial implementation/understanding of DMN, but after discussing it further with Gary, it seems that because there is currently no way to define in FEEL a type like "feel:function", that the implementation has to "implicitly" understand that the BKM is a function that returns a "feel:number" due to that type definition.

It is a mess, I would gladly change that if we can get it fixed in the spec. (or if my understanding of the issue turns out to be wrong)

from tck.

I agree with Daniel. According to DMN spec the typeRef of the variable is a FunctionType. The type of the body is the return type of the function. The FunctionType doesn't have to be specified, it can be inferred from the types of the parameters and the return type.

We should raise the issue at the next RTF.

We have two options:

• keep the spec as it is and change the tests
• change the spec so that the type of the variable is the return type and keep the tests as they are.

My preference is to change the tests. I don't see anything wrong with the spec. The function type can be inferred from parameters and return type.

from tck.

Our preference is also to change the DMN TCK tests. Currently there is nothing wrong with the specification. Only a feel:function type is missing, which can be introduced for DMN 1.2

--> To be compliant with the specification, we should change the DMN models of the affected test cases

from tck.

Discussed this further with other people, Denis, Gary, Bruce. It seems like the best approach will be to remove the typeRef from the BKM variables as suggest already by @DanielThanner .

@opatrascoiu it would be good if you can include something like a "feel:function[...]" type on your type improvement proposal to the RTF for 1.2.

from tck.

Agreed to update test cases. Leaving issue in to track until we get the changes make.

from tck.

Created pull request #120 with changed dmn files.

from tck.

@etirelli I'll look into it next week. Hopefully, I'll have more time.

from tck.

This is resolved by the PR that was merged today

from tck.