Comments (4)
I think this is implementation specific, but I believe this should not happen. If there is an error, the decision should return null and the error should be published by the engine.
from tck.
It is pretty late here now, but wanted to start a discussion on that topic, because I really think this is a serious problem in the DMN standard:
This is a simple FEEL expression that produces a valid result, even though it contains a semantic error:
{myFn: function(a) a < 5, res: if myFn("6") then "DECLINED" else "ACCEPTED"}.res
Now imagine this is just a tiny part of a huge business model, proceeding to work with the "ACCEPTED" result string which is the result of an error situation (comparing a number with a string) potentially ending up with the approval of an unjustified loan.
I am exaggerating by purposo to point that out clearly.
Imagine how hard it is to debug such stuff, once it is part of a huge model with thousands of expressions and run with unknown data from a webservice or whatever (if "6" was an parameter for this expression).
From my point of view, evaluation must stop at the point where the if statement evaluates against null.
Everything else could be harmful and lead to completely valid looking results and scores based on a semantic error situation.
What is your guys opinion on that?
from tck.
The DMN 1.1 is clear on handling errors. As @etirelli said above, if there is an error, null is propagated up. Both SQL & OCL have a similar approach.
Capturing / propagating errors up to the decision parent can be done via Annotations or at the implementation level (e.g. using a Prolog like accumulator pattern ).
Having an exception-like approach looks like a big change to me.
from tck.
I think we are clear on how error happen and how the testing works around it which is to say that if an error occurs at any point, the "error occurred" flag is set, and it does not matter how many times it is set, nor does it matter if the final result is null or not. The RTF can discuss any possible extensions to the standard. But since the use by the TCK is clear I am going to close this issue.
from tck.
Related Issues (20)
- Clarify `null` handling in `FunctionInvocation` HOT 6
- Cover comparisons
- Create transitive import test cases based on snippets in DMN15-58 HOT 2
- Doubtful typing on overloaded built-in function in test HOT 2
- Report does not work under windows
- The test cases table breaks up around Compliance-Level-3
- New PRs ... but deleting them. The PRs have dragged in CL/LF differences HOT 2
- Patches to test cases HOT 4
- Confused about decision service encapsulatedDecisions - ambiguous - is ch11 example correct? HOT 5
- Task list for DMN 1.6
- Optional fn params vs null values HOT 4
- Question to test case `decision_015` in `0084-feel-for-loops.dmn` HOT 1
- Quesion to test case `nested009` in `1146-feel-context-put-function.dmn` HOT 2
- 0014-loan-comparison assumes that sorting keeps the original order HOT 2
- breaking change?: what do do with range equality? What is 'undefined'? HOT 4
- Is `[100] = 100` false or null? HOT 4
- Does @"P0D" = "P0Y" give `true` or `null` (or false?) ? HOT 3
- The new text for type conversions in "10.3.2.9.4 Type conversions" misses some use cases HOT 2
- Spec permits ranges to use new `=` and `!=` comparison operators - but it doesn't make much sense (to me) HOT 3
- TCK is using yearMonthDuration/dayTimeDuration/dateTime typeRefs HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tck.