Giter VIP home page Giter VIP logo

Comments (5)

Dobiasd avatar Dobiasd commented on September 13, 2024 1

Ok, I pushed the change (including a comment). ✔️

from functionalplus.

offa avatar offa commented on September 13, 2024 1

Fixed by #302

from functionalplus.

Dobiasd avatar Dobiasd commented on September 13, 2024

Oh, what an interesting false positive (I guess), thanks!

I'll see if I can build a workaround for FunctionalPlus, and maybe even a minimal example to reproduce the problem.

from functionalplus.

Dobiasd avatar Dobiasd commented on September 13, 2024

I've experimented locally, and replacing return xs; with return Container({xs.front()}); seems to work. It's not beautiful, but it should also not be a significant performance penalty. Shall we use this? And would you like to push it to your branch, or shall I open a new one?

from functionalplus.

offa avatar offa commented on September 13, 2024

I've experimented locally, and replacing return xs; with return Container({xs.front()}); seems to work.

Interesting 🤔.

Shall we use this? And would you like to push it to your branch, or shall I open a new one?

If it works, why not? :-) There' should be a comment documenting the reason though.

And would you like to push it to your branch, or shall I open a new one?

You should have write access to me PR, feel free to add commits directly. 👍 Otherwise, what suits you best.

from functionalplus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.