Giter VIP home page Giter VIP logo

Comments (4)

fliiiix avatar fliiiix commented on July 22, 2024

Why? adding tags is not destructive

from docat.

palto42 avatar palto42 commented on July 22, 2024

Agree that it's not directly destructive, but it could still have a significant impact if a tag is changed incorrectly.

As an example, the tag may be used in pipelines to deploy the latest version of a code.
Even for manual usage it could mislead the user if a wrong tag is applied.

Not big issue for me, but I was surprised that it worked w/o API key.

from docat.

fliiiix avatar fliiiix commented on July 22, 2024

Also your assumption that you need a token to upload is wrong https://github.com/docat-org/docat/blob/main/docat/docat/app.py#L227 only the destructive action of overriding a existing version requires the token

this was a deliberate decision to make the usage as simple as possible but less secure

im closing this for now, maybe this is something that could be configurable - but its more code and complexity

from docat.

palto42 avatar palto42 commented on July 22, 2024

Thanks for the clarification.

from docat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.