Giter VIP home page Giter VIP logo

Comments (6)

nfrmtkr avatar nfrmtkr commented on September 22, 2024

We've fixed the race condition with following patch:
0001-Fixed-possible-data-race-in-ACE_Future-set-get.patch

The following code we used for testing:
acefuturetester.tar.gz

from ace_tao.

jwillemsen avatar jwillemsen commented on September 22, 2024

Please open a pull request with your patch add your test under ACE_wrappers/tests so that it is compiled/tested as part of our test suite

from ace_tao.

jwillemsen avatar jwillemsen commented on September 22, 2024

Maybe determine the max threads based on the number of cpu cores on the system and run it for some minutes, a run of 4 hours is to long for our test suite. Maybe split the PR in two, one with just the test extension, second with the fix

from ace_tao.

nfrmtkr avatar nfrmtkr commented on September 22, 2024

The test Future_Test.cpp will test this from functional point of view.
The issue can't be easily reproduced. It requires fast machines and it depends on the CPU and compiler being used.

from ace_tao.

jwillemsen avatar jwillemsen commented on September 22, 2024

I think it would be helpful to have the additional test be added to future_test but just do some interations and make it possible to control the amount of iterations on the commandline. What kind of CPU/compiler are required, some background information on why it happens only with some specific cpu/compiler would be helpful, it is very likely that we have more constructs like this

from ace_tao.

jwillemsen avatar jwillemsen commented on September 22, 2024

Looks similar to #2170

from ace_tao.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.