Giter VIP home page Giter VIP logo

Comments (4)

crazy-max avatar crazy-max commented on June 12, 2024

I repro as well with:

image

Do you have the same error?

from build-push-action.

alessfg avatar alessfg commented on June 12, 2024

Yep! That's one of the errors I'm seeing. The actual error depends on the "format" I try but they all follow the same style.

from build-push-action.

crazy-max avatar crazy-max commented on June 12, 2024

Ok so this error #1072 (comment) is related to csv parsing in build command (buildx) which make sense because quotes should take the whole column. Correct syntax is:

type=image,"name=ghcr.io/nginxinc/nginx-unprivileged,docker.io/nginxinc/nginx-unprivileged",push-by-digest=true,name-canonical=true,push=true

But still fails with:

Error: buildx failed with: ERROR: invalid value docker.io/nginxinc/nginx-unprivileged

I think this is related to the csv-parse lib that we are using in our actions toolkit: https://github.com/docker/actions-toolkit/blob/7fb507050a318dff09c0e4dd89c14a569fc62548/src/util.ts#L40 that is stripping the quotes where it should not:

/usr/bin/docker buildx build --file ./Dockerfile --iidfile /home/runner/work/_temp/docker-actions-toolkit-8En3Bu/iidfile --output type=image,name=ghcr.io/nginxinc/nginx-unprivileged,docker.io/nginxinc/nginx-unprivileged,push-by-digest=true,name-canonical=true,push=true ...

So might need changes in actions-toolkit. Still digging.

from build-push-action.

crazy-max avatar crazy-max commented on June 12, 2024

Ok after tests in docker/actions-toolkit#273, we need to keep quotes around fields for this input by setting quote to false: https://csv.js.org/parse/options/quote/

from build-push-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.